Scheduler jobs interceptions fixed #656
Conversation
| } | ||
|
|
||
| func (r *AWSEndpointServicePrincipal) GetJobID(job string) string { | ||
| return r.Namespace + "/" + r.Name + "/" + job | ||
| func (principal *AWSEndpointServicePrincipal) GetJobID(job string) string { |
There was a problem hiding this comment.
Please rename receiver principal to p
| @@ -63,7 +63,7 @@ type AWSEncryptionKeyList struct { | |||
| } | |||
|
|
|||
| func (aws *AWSEncryptionKey) GetJobID(jobName string) string { | |||
| return client.ObjectKeyFromObject(aws).String() + "/" + jobName | |||
| return aws.Kind + "/" + client.ObjectKeyFromObject(aws).String() + "/" + jobName | |||
There was a problem hiding this comment.
Maybe just use UUID-Based Naming. It would be like aws.ObjectMeta.UID + "/" + jobName. You can even add client.ObjectKeyFromObject(aws).String() there. WDYT?
There was a problem hiding this comment.
The following solution allows us to easly watch in the operator logs for which resource job is created. However, we can also add UUID to the job name. What do others think about a pattern with UUID included?metadata.uuid/metadata.kind/metadata.namespace/metadata.name/jobid
It looks a bit big, but it provides more uniqueness for JobIDs.
There was a problem hiding this comment.
I discussed it with @ribaraka and decided to use metadata.kind/metadata.namespace/metadata.name/jobId because it is easier to manage jobs via the operator logs.
worryg0d
force-pushed
the
scheduler-hot-fix
branch
from
a7922cb
to
6df19fc
Compare
Problem
There is method
GetJobIDfor each k8s resource that needs a scheduler and the current implementation of the method uses the following patter:metadata.namespace/metadata.name/jobname. When there are two resources with differentKind, but the same namespaced names it causes intersections in the scheduler job, so we can not run a job for the second resource.This PR fixes the problem by adding a
Kindof resources for eachGetJobIDmethod.New pattern:
metadata.kind/metadata.namespace/metadata.name/jobname