Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VPC Peering hanging issue #33

Merged
merged 4 commits into from
Jun 22, 2020
Merged

Fix VPC Peering hanging issue #33

merged 4 commits into from
Jun 22, 2020

Conversation

arjunrajshekhar
Copy link
Contributor

Resolves #31

Fixes an infinite loop on vpc peeering with clusters that are not in the "PROVISIONED" status.
A timeout has also been added with an appropriate fail message.

josiahhalme
josiahhalme previously approved these changes Jun 19, 2020
Copy link

@josiahhalme josiahhalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with provisioning/running/deferred cluster status, looks to fix the problem. Timeout also works and has a sensible error 👍

peter-toms
peter-toms previously approved these changes Jun 22, 2020
instaclustr/resource_vpc_peering.go Show resolved Hide resolved
@jordanbraiuka jordanbraiuka merged commit a26485f into instaclustr:master Jun 22, 2020
@arjunrajshekhar arjunrajshekhar deleted the feature/fix-vpc-peering-infinite-loop branch September 30, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPC Peering creation hang
5 participants