-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: IQL Example #13
add: IQL Example #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working through the noteobook, but here are some comments in the interim.
In addition to the attached comments, also:
- Re: naming convention, we do sometimes use ALL_CAPS for constants, but not for other things. e.g.
Q_NETWORK
can just beq_network
, etc. - Could we rename the notebook itself to match the pattern seen elsewhere?—e.g.
quickstart_iql_matrax.ipynb
or similar.
It's looking fab though! Great comments, and clear structure. Will continue looking soon :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @JemmaLDaniel!
What?
Why?