WIP: Rewrite e2e tests to golang #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace current configmap package with instana-agent-config secret package as the values will be secrets from here on - Mount config directory from secret - Add feature to disable backend template generation - Update READMEs local development guide with additional details to make the project run correctly Signed-off-by: Fredrik Gundersen <fredrik.gundersen@ibm.com>
…rease coverage to 100% Signed-off-by: Fredrik Gundersen <fredrik.gundersen@ibm.com>
…source Signed-off-by: Fredrik Gundersen <fredrik.gundersen@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have a shell script executing e2e tests.
I would consider re-implementing them in pure go to keep them extensible in the long run.
While searching for existing solutions, I found that there is an e2e framework available at the Kubernetes SIGs: https://github.com/kubernetes-sigs/e2e-framework/tree/main/examples/real_cluster
We could either rely on that (which forced a few updates on dependencies) or we could fallback to pure command execs to mimic the bash behavior with a bit additional golang logic, e.g. for waiting on resources.