Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Tag Validation & Reporting #247

Merged
merged 5 commits into from
Jul 16, 2020
Merged

Improved Tag Validation & Reporting #247

merged 5 commits into from
Jul 16, 2020

Conversation

pglombardo
Copy link
Contributor

@pglombardo pglombardo commented Jul 16, 2020 •
edited
Loading

With this PR, we switch to repr for representing objects and add more tests to validate various scenarios.

Invalid tag keys now log a DEBUG message and are discarded:

11:03:52 DEBUG (non-fatal) span.set_tag: tag names must be strings. tag discarded for <type 'int'>

@pglombardo pglombardo merged commit 0cebf74 into master Jul 16, 2020
@pglombardo pglombardo deleted the python-sets branch July 16, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pglombardo