Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blinker): Always set 500 on exception signal #423

Merged
merged 1 commit into from
May 16, 2023

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented May 16, 2023

Removes a TODO item, and re-enables the assertion of the status code being 500 on the wsgi span.

@Ferenc- Ferenc- requested review from pvital and basti1302 May 16, 2023 08:31
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- force-pushed the blinker-exception-status-code branch from ad3fc62 to c0ccbd0 Compare May 16, 2023 11:32
@Ferenc- Ferenc- merged commit 5525533 into master May 16, 2023
@Ferenc- Ferenc- deleted the blinker-exception-status-code branch May 16, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants