Fix: remove the check for the Server header of the Instana agent. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
reviewed
May 22, 2023
pvital
force-pushed
the
remove_check_for_server_header
branch
from
e0ec53c to
17d576d
Compare
basti1302
approved these changes
May 22, 2023
Ferenc-
requested changes
May 23, 2023
There was a problem hiding this comment.
Good work so far. We are getting there.
The coverage report shows that the failed attempt is nicely covered with the test case,
while the successful attempt is not yet covered.
Although the production code around the succesful attempt is minuscule.
I still think covering the succesful attempt would be valuable, not just because we can't have a functioning system without a successful connection attempts,
but also because this change is about enabling successful connections in a broader situation.
so any other change is secondary priority here.
Ferenc-
reviewed
May 23, 2023
pvital
force-pushed
the
remove_check_for_server_header
branch
from
17d576d to
f9a8988
Compare
The check for the Server header of the Instana agent can break the announce procedure in service meshes when there is a proxy between the tracer and the Instana agent. This happens because some proxies do not forward the original Server header. So instead, the collector checks whether the HTTP status code is in the 2xx range. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
remove_check_for_server_header
branch
from
f9a8988 to
4211415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for the Server header of the Instana agent can break the announce procedure in service meshes when there is a proxy between the tracer and the Instana agent. This happens because some proxies do not forward the original Server header. So instead, the collector checks whether the HTTP status code is in the 2xx range.