Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: Certifi #437

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Remove Unused Dependency: Certifi #437

merged 1 commit into from
Aug 11, 2023

Conversation

gdrosos
Copy link
Contributor

@gdrosos gdrosos commented Aug 9, 2023

Summary

This pull request removes the unused dependency certifi from the project's dependency list in the setup configuration file. This detection and removal is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The certifi package was added in this commit 5 years ago, but upon detailed analysis of the codebase, it was found that it is not currently being utilized within the project. Removing this unused dependency can decrease the overall footprint of the application, reduce potential security risks, and simplify the dependency management process.

Changes

  • Removed the dependency to the certifi PyPI package from the setup.py.

Impact

  • Reduced Package Size: The removal of this unused dependency will result in a decrease in the overall size of the installed packages.
  • Simplified Dependency Tree: Eliminating unnecessary dependencies makes the project more maintainable and can enhance installation efficiency.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@gdrosos the signed-off-by was not found in the following 1 commits:

  • cb3277b: Remove unused dependency: certifi

📝 What should I do to fix it?

All proposed commits should include a sign-off in their messages, ideally at the end.

❔ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:

By making a contribution to this project, I certify that:

a. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

b. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

c. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

d. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@gdrosos gdrosos changed the title Remove unused certifi dependency Remove unused dependency: certifi Aug 9, 2023
Signed-off-by: gdrosos <t8180024@aueb.gr>
@gdrosos gdrosos changed the title Remove unused dependency: certifi Remove Unused Dependency: Certifi Aug 10, 2023
@Ferenc- Ferenc- merged commit acc50a3 into instana:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants