-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unittest: formatted test folder structure and improved unittest coverage #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
CagriYonca
force-pushed
the
otel/unittests
branch
4 times, most recently
from
October 4, 2024 08:26
cd3fc15
to
4ff5db5
Compare
pvital
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few requests
CagriYonca
force-pushed
the
otel/unittests
branch
2 times, most recently
from
October 4, 2024 14:28
ce56b02
to
5dbf9ad
Compare
CagriYonca
force-pushed
the
otel/unittests
branch
2 times, most recently
from
October 10, 2024 16:26
fdc7208
to
b9bf61e
Compare
CagriYonca
force-pushed
the
otel/unittests
branch
from
October 14, 2024 08:04
b9bf61e
to
25d56f9
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
pvital
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on the modules below, increased existing unittests and created non-existing:
• src/instana/collector/base.py (98% coverage)
• src/instana/collector/helpers/runtime.py (97%)
• src/instana/collector/host.py (96%)
• src/instana/collector/utils.py (100%)
• src/instana/propagators/base_propagator.py (96%)
• src/instana/sampling.py (93%)
• src/instana/util/traceutils.py (97%)
Modified folder structures in tests folder, used the same structure that src/instana folder has.