Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests with inconsistent trace and span ids #664

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix flaky tests with inconsistent trace and span ids #664

merged 1 commit into from
Oct 29, 2024

Conversation

GSVarsha
Copy link
Contributor

Failure scenarios: case-1 with trace_id, case-2 with parent relationship (parent_id, span_id)

Considering cases when the hexadecimal string contains all the characters as digits.

>>> id=8360669476235335784
>>> hexid=hex(id)[2:]
>>> hexid
'7407109787755868'
>>> hexid.isdigit()
True

@GSVarsha
fix flaky trace and span ids
889d805 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Oct 29, 2024
@GSVarsha GSVarsha added the bug label Oct 29, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Oct 29, 2024
@GSVarsha
Copy link
Contributor Author

GSVarsha commented Oct 29, 2024 •
edited
Loading

🗒️ Confirmed that the tracer-test-suite is passing with these changes.

@GSVarsha GSVarsha requested review from pvital and CagriYonca October 29, 2024 07:54
pvital
pvital approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 84373e7 into main Oct 29, 2024
14 checks passed
@GSVarsha GSVarsha deleted the fix_flaky_trace_span_ids branch October 29, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@GSVarsha GSVarsha

Labels
bug
Projects
None yet
Milestone
H2-2024
Development

Successfully merging this pull request may close these issues.
2 participants
@GSVarsha @pvital