Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: removed protobuf from requirements list #667

Merged
merged 2 commits into from
Nov 11, 2024
Merged

enhancement: removed protobuf from requirements list #667

merged 2 commits into from
Nov 11, 2024

Conversation

CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Nov 5, 2024 •
edited
Loading

This PR removes the protobuf from dependencies list to solve the problem below version 4.0.0:

AttributeError: module 'google._upb._message' has no attribute 'Message'
TODO: Remove this when support for 4.0.0 is done
protobuf<4.0.0

Updating protobuf is also required to solve google-cloud-storage dependency problems for versions >= 2.14.2 for python 3.11 and 3.12

@CagriYonca CagriYonca added the dependencies Pull requests that update a dependency file label Nov 5, 2024
@CagriYonca CagriYonca self-assigned this Nov 5, 2024
@CagriYonca CagriYonca requested a review from a team as a code owner November 5, 2024 14:51
pvital
pvital requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick request change.

pyproject.toml Outdated Show resolved Hide resolved
@CagriYonca
fix: removed protobuf from requirements list
bb097ec 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca
updated stan files to support newer version of protobuf
893cf4b 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca CagriYonca changed the title enhancement: updating protobuf version to >=4.21.1 enhancement: removed protobuf from requirements list Nov 11, 2024
@CagriYonca CagriYonca requested a review from pvital November 11, 2024 09:32
pvital
pvital approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Good job @CagriYonca.

@CagriYonca CagriYonca merged commit aafb2aa into main Nov 11, 2024
14 checks passed
@CagriYonca CagriYonca deleted the protobuf_update branch November 11, 2024 10:40
@CagriYonca CagriYonca mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

Assignees

@CagriYonca CagriYonca

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CagriYonca @pvital