Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(flaky tests): added announce function to conftest #669

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix(flaky tests): added announce function to conftest #669

merged 2 commits into from
Dec 16, 2024

Conversation

CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Nov 6, 2024 •
edited
Loading

  • Added announce function to conftest
  • Removed duplicated code file

@CagriYonca CagriYonca added the bug label Nov 6, 2024
@CagriYonca CagriYonca self-assigned this Nov 6, 2024
@CagriYonca CagriYonca requested a review from a team as a code owner November 6, 2024 14:46
GSVarsha
GSVarsha reviewed Dec 6, 2024
View reviewed changes
tests/agent/test_host.py Outdated Show resolved Hide resolved
@CagriYonca CagriYonca force-pushed the fix_pubsub branch 2 times, most recently from 58fa6a5 to 24c35f9 Compare December 16, 2024 08:56
@CagriYonca CagriYonca requested a review from GSVarsha December 16, 2024 08:56
GSVarsha
GSVarsha approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CagriYonca
fix(pubsub): flaky tests
b2684e2 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca
enhancement: removed duplicated code
ae289fc 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca CagriYonca merged commit 7f969b4 into main Dec 16, 2024
12 of 14 checks passed
@CagriYonca CagriYonca deleted the fix_pubsub branch December 16, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

@CagriYonca CagriYonca

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CagriYonca @GSVarsha