Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flask Instrumentation through WSGI middleware. #8

Merged
merged 23 commits into from
Jul 27, 2017
Merged

Flask Instrumentation through WSGI middleware. #8

merged 23 commits into from
Jul 27, 2017

Conversation

pglombardo
Copy link
Contributor

@pglombardo pglombardo commented Jul 25, 2017 •
edited
Loading

WSGI is the equivalent to rack in the ruby world. Here we add WSGI middleware that can be used to instrument many frameworks that use WSGI (including Flask).

Remaining issues:

  • App name is not properly reported
  • When runtime only, we should report process name as name (currently sensory.pyc)
  • Context headers are not currently returned.

pglombardo added 20 commits July 25, 2017 11:28
@pglombardo
Better json encoding and fix error logging.
94928a7
@pglombardo
Remove debug message
c5c7491
@pglombardo
Linter hapiness.
e3b009a
@pglombardo
Protect inject/extract with try/catch
5dfe863 
...to avoid breaking customer apps in case of failure.
@pglombardo
General WSGI instrumentation for many frameworks.
570bb1c
@pglombardo
Add Flask instructions to README
5900385
@pglombardo
Add wsgi to list of registered spans.
f33b44f
@pglombardo
Fix formatting and remove unneeded lines
da26d78
@pglombardo
Merge branch 'master' into flask
b1393e4
@pglombardo
Set flask hook point for autowrapt
24a28b1
@pglombardo
Flask hook instrumentation
73ca3a4
@pglombardo
Remove debug line
b734575
@pglombardo
Merge branch 'flask' of github.com:instana/python-sensor into flask
0ddf327
@pglombardo
Simplify env var hooks.
9729bbc
@pglombardo
Updated README per instrumentation changes.
e3be59b
@pglombardo
Flask == Flask, not Django thx Fabian
cafb615
@pglombardo
Add runtime only hook & instrumentation
71ea5ba
@pglombardo
Add check that we really want runtime only
0503814
@pglombardo
Add list type support to the HTTP propagator
a731c3c
@pglombardo
Enable inject for response headers.
0e15586
@pglombardo
Copy link
Contributor Author

instana python flask 2017-07-27 at 14 38 22
instana python flask 2017-07-27 at 14 39 18

@pglombardo
Copy link
Contributor Author

pglombardo commented Jul 27, 2017 •
edited
Loading

Go app calling Python Flask app.

instana go to python flask trace 2017-07-27 at 15 21 13

@pglombardo pglombardo merged commit c654a73 into master Jul 27, 2017
@pglombardo pglombardo deleted the flask branch July 27, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pglombardo