-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks stream when midroll ads appear #11
Comments
Fix stream breaking when there's only ads and no underlying stream to show, resulting in the extension filtering too much #11. Fix sequence numbers not being reset correctly for midroll ads. Add explanatory comments.
This is most likely fixed with 6dc974a, but preroll ads need testing now. |
Did some digging and here are my results for a midroll: Last non-Ad
First ad
First non-Ad
So it seems there's actually a 42s gap without non-Ad segments. Here's the raw HAR with sensitive values replaced. I've tried to inject a ffmpeg -f lavfi -i color=c=black:s=1920x1080:d=2 -c:v h264 -vf "drawtext=fontfile=/usr/share/fonts/truetype/ubuntu/UbuntuMono-B.ttf:fontsize=60: fontcolor=white:x=(w-text_w)/2:y=(h-text_h)/2:text='Blocking Ads. Stay tuned.'" output.ts but the player doesn't seem to like that.
|
Here's a gist of what I've tried so far regarding injecting the generated ts segment using the |
See #10.
I have a tough time actually getting a midroll ad to debug this. It'd a great help if someone encounters such an ad and could attach debug output as described in #8 by @stoically.
The text was updated successfully, but these errors were encountered: