Merge pull request #370 from sigwinhq/perf/gc

fix: allow importer/exporter to run GC each 50 items
instride-ch · Sep 27, 2022 · 5a007b1 · 5a007b1
2 parents e1e4904 + c875927
commit 5a007b1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/DataDefinitionsBundle/Exporter/Exporter.php b/src/DataDefinitionsBundle/Exporter/Exporter.php
@@ -119,7 +119,6 @@ private function runExport(
         UnpublishedHelper::hideUnpublished(
             function () use ($definition, $params, $total, $fetcher, $provider, $fetcherContext) {
                 $count = 0;
-                $countToClean = 1000;
                 $perLoop = 50;
                 $perRun = ceil($total / $perLoop);
 
@@ -134,7 +133,7 @@ function () use ($definition, $params, $total, $fetcher, $provider, $fetcherCont
                         try {
                             $this->exportRow($definition, $object, $params, $provider);
 
-                            if (($count + 1) % $countToClean === 0) {
+                            if (($count + 1) % $perLoop === 0) {
                                 Pimcore::collectGarbage();
                                 $this->logger->info('Clean Garbage');
                                 $this->eventDispatcher->dispatch(

diff --git a/src/DataDefinitionsBundle/Importer/Importer.php b/src/DataDefinitionsBundle/Importer/Importer.php
@@ -235,7 +235,7 @@ private function runImport(
         }
 
         $count = 0;
-        $countToClean = 1000;
+        $countToClean = 50;
         $objectIds = [];
         $exceptions = [];