New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty array and wrong entity manager #314

Merged

dpfaffenbauer merged 2 commits into instride-ch:master from punk-raider:fix/empty-array-and-wrong-entity-manager

Jun 21, 2021

punk-raider commented Jun 14, 2021

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no

Fix importing new import/exportDefinition:

importing command expects InvalidArgumentException when no definition exists in system
WAS: error wash thrown
IS: correct exception is thrown

Fix wrong entity model in import commands:

@doctrine.orm.default_entity_manager can't handle Definition entity

Michał Ryczańczyk added 2 commits

June 14, 2021 14:50


          Fix importing new Import/ExportDefinition. Throwing `InvalidArgumentE…

ecf716d

…xception` instead of error.


          Fix wrong entity manager for import commands.

65dd708

dpfaffenbauer added this to the 4.0.0 milestone

dpfaffenbauer assigned punk-raider

dpfaffenbauer self-requested a review

June 21, 2021 10:08

dpfaffenbauer approved these changes

View reviewed changes

dpfaffenbauer merged commit 2c334f5 into instride-ch:master

Collaborator

dpfaffenbauer commented Jun 21, 2021

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet