-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ExcelProvider #319
Fix ExcelProvider #319
Conversation
dpfaffenbauer
commented
Aug 16, 2021
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Fixed tickets | #318 |
This fixes the problem with the processor callback function. The parameter $data in importRow() is not nullable at the moment. This exception is catched, but is not ideal.
This will not make the first $row being null count as a row being processed. What do you think @dpfaffenbauer ? |
I would actually have to test that use-case myself. I'll comeback to you with a solution |
Ok, thanks |
This code in Importer:importRow() can be removed then as well since parameter $data is not nullable, so this code already never gets executed atm. |
@paulverdu Did the changes you recommended. Seems that in fact you are right here :) |
Awesome. Hope we can merge this soon, so we can continue testing our application 😄 |
done :) |