Event "data_definitions.import.total" never gets dispatched #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 16, 2021 15:08
By counting the traversable object before creating the IteratorIterator object, no exception will be thrown when looping over the dataset after counting the elements.
|
works for me, what does @dkarlovi think? |
dkarlovi
requested changes
Aug 17, 2021
src/DataDefinitionsBundle/Provider/TraversableImportDataSet.php
Outdated
Show resolved
Hide resolved
src/DataDefinitionsBundle/Provider/TraversableImportDataSet.php
Outdated
Show resolved
Hide resolved
| { | ||
| $this->iterator = new \IteratorIterator($iterator); | ||
| $this->count = iterator_count($iterator); |
There was a problem hiding this comment.
Can we make this lazy? Only count it if the count is requested.
There was a problem hiding this comment.
It's not possible to do a count on a iterator since you can only rewind ones. That's why im doing this in the constructor before the IteratorIterator object is created. The count is also always requested in the importer.
|
@dpfaffenbauer looked at it, posted a review. |
dkarlovi
approved these changes
Aug 17, 2021
|
@dpfaffenbauer If we could merge this one as well. Would be awesome 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Importer.php the event "data_definitions.import.total" never gets get dispatched when $data is an object of type \Wvision\Bundle\DataDefinitionsBundle\Provider\TraversableImportDataSet.
Fixed this by adding Countable interface and setting the count on object creation.