Checks if parameters are set because of strict_types directive #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpfaffenbauer
approved these changes
Oct 6, 2021
|
@aarongerig please review as well |
aarongerig
approved these changes
Oct 6, 2021
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current 4.0 state its not possible to export any definition because of the strict_types directive in the ObjectsFetcher.php class. Since the behavior changed, a simple
if($params['something'])query will result in an error message. Only workaround is to set all parameters that are queried until this is fixed.This change proposes to check if parameters are actually available through
isset, as it is done already withroot