Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Writable] only allow writable definitions to be saved #394

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

dpfaffenbauer
Copy link
Collaborator

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Copy link
Collaborator

@dkarlovi dkarlovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpfaffenbauer dpfaffenbauer merged commit a6a33ce into instride-ch:4.0 Oct 2, 2023
1 of 5 checks passed
@dpfaffenbauer dpfaffenbauer deleted the issue/writable branch October 2, 2023 07:40
@@ -24,7 +24,6 @@ class PimcoreSettingsListener
{
public function indexSettings(IndexActionSettingsEvent $settingsEvent): void
{
$settingsEvent->addSetting('data-definitions-import-definition-writeable', (new ImportDefinition())->isWriteable());
$settingsEvent->addSetting('data-definitions-export-definition-writeable', (new ExportDefinition())->isWriteable());

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just found the issue with this: it is used for the Add button, it gets disabled without this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Add" button (new import/export profile) will be disabled when not in debug because it relies on this to be present.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a problem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because you can't add new profiles even though they're writable? You can edit existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants