Fixes on the current version. #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tip-top-b
commented
May 28, 2024
•
tip-top-b
commented
- Returning the id to the function, to prevent overwriting definitions with the same name.
- Adding commands for converting the old structure to the new structure, and systems that have to be upgraded.
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes/no |
| Fixed tickets | #... |
- Add IdGenerator. - Introduce a new command to migrate old export and import definitions to yaml.
|
@tip-top-b This adds a new ID int field to the definitions? |
# Conflicts: # src/DataDefinitionsBundle/Model/ExportDefinition.php # src/DataDefinitionsBundle/Model/ImportDefinition.php
|
@tip-top-b I see why you added that again, and it makes total sense! I made some further adjustments and refactorings. It didn't quite well work in all scenarios, for example if configured as settings-store. |
|
@dpfaffenbauer thanks a lot. |
|
@tip-top-b thank you ;) I will do a release tomorrow. will be 5.1. major bc break though, but necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.