[License] change license to Dual-License with GPL and Data Definition Commercial License (DDCL) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s Commercial License (DDCL)
…s Commercial License (DDCL)
aarongerig
requested changes
Oct 17, 2024
…s Commercial License (DDCL)
…s Commercial License (DDCL)
|
@aarongerig please approve once you are fine with it |
aarongerig
reviewed
Oct 17, 2024
Comment on lines
+24
to
+25
| public function __construct( | ||
| ) { |
There was a problem hiding this comment.
@dpfaffenbauer This seems to be a weird CS rule. Empty constructor should not be split across two lines and with that indentation IMO. WDYT?
There was a problem hiding this comment.
empty constructor per-se should not exist.
We use the same CS rule in CoreShop. I actually only added it for the License headers :D
There was a problem hiding this comment.
Alright, then that's fine with me. :)
aarongerig
approved these changes
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.