Harden GitHub action workflows #237
Merged
+119
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use SHAs instead of tag names to refer to action versions. Dependabot will help use manage the SHAs. Update permissions to minimum necessary. Add harden-runner to monitor egress of action. After some time, we can tighten the egress to limit hosts/ports. We also update the maintainers script to generate markdown which passes markdownlint checking. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
bjhargrave
requested review from
nathan-weinberg and
russellb
and removed request for
a team
|
@bjhargrave overall looks good but why was the DCO check removed? |
@nathan-weinberg It is not removing the DCO check. That config permitted org members to skip the Signed-off-by in their commit messages. I don't think we want that anymore. It was part of the initial commit for this repo to get things going. https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members |
nathan-weinberg
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use SHAs instead of tag names to refer to action versions. Dependabot will help us manage the SHAs.
Update permissions to minimum necessary.
Add harden-runner to monitor egress of action. After some time, we can tighten the egress to limit hosts/ports.
We also update the maintainers script to generate markdown which passes markdownlint checking.