Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: fix the knowledge doc repo path and repo url/path validation #473

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

nerdalert
Copy link
Member

  • Native submissions neeed /taxonomy-knowledge-docs appended to the path after NEXT_PUBLIC_LOCAL_TAXONOMY_ROOT_DIR
  • Since knowledge docs are not just a URL, change the validation to text instead of url.

- Native submissions neeed /taxonomy-knowledge-docs appended
to the path after NEXT_PUBLIC_LOCAL_TAXONOMY_ROOT_DIR

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
- Since knowledge docs are not just a URL, change the validation
to text.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 11e94e6 into instructlab:main Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants