Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated deprecated pydantic import #494

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

zboyles
Copy link
Contributor

@zboyles zboyles commented Mar 7, 2024

Update import statement and parameter name in validate_sources example method.

This was the only instance of a pydantic_core v2.10.0 deprecated import change found in the repo.


Ellipsis 🚀 This PR description was created by Ellipsis for commit faa70a9.

Summary:

This PR updates a deprecated pydantic import and parameter name in the validate_sources method of the Fact class in /docs/examples/exact_citations.md.

Key points:

  • Updated deprecated pydantic import in /docs/examples/exact_citations.md.
  • Replaced FieldValidationInfo with ValidationInfo.
  • Updated parameter name in validate_sources method of Fact class.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to faa70a9
  • Looked at 23 lines of code in 1 files
  • Took 33 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 85%.
1. docs/examples/exact_citations.md:23:
  • Assessed confidence : 50%
  • Comment:
    The import statement and parameter name have been updated correctly according to the new version of pydantic. Please ensure that the mkdocs.yml file is updated to include this new .md file.
  • Reasoning:
    The PR author has updated the import statement and parameter name in the validate_sources method. The changes seem to be in line with the deprecated import change in pydantic_core v2.10.0. The changes are consistent with the new version of the library and there doesn't seem to be any logical, performance, or security bugs introduced. The code is not repeated and the naming conventions are consistent. The documentation has been updated to reflect the changes. However, I need to check if the mkdocs.yml file has been updated to include this new .md file.

Workflow ID: wflow_rRjbYFOa3eNgqQDe


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@jxnl jxnl merged commit 6154578 into instructor-ai:main Mar 7, 2024
7 of 8 checks passed
@zboyles zboyles deleted the deprecated-renaming branch March 7, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants