Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dependencies for anthropic and xmltodict #519

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jpetrantoni
Copy link
Contributor

@jpetrantoni jpetrantoni commented Mar 21, 2024

Fixes #518

When running pip install instructor[anthropic] anthropic and xmltodict are not installed and the following warning is shown WARNING: instructor 0.6.5 does not provide the extra 'anthropic'

  1. Adds optional depencencies to pyproject.toml

Ive tested to ensure pip install instructor does not install anthropic and xmltodict unintentionally, as well as pip install instructor[anthropic] to verify there is no issues with install anthropic and xmltodict.


Ellipsis 🚀 This PR description was created by Ellipsis for commit 32d17e0.

Summary:

This PR modifies 'pyproject.toml' to add 'anthropic' and 'xmltodict' as optional dependencies, ensuring they are not installed unintentionally and are correctly installed with 'pip install instructor[anthropic]'.

Key points:

  • Added optional dependencies for 'anthropic' and 'xmltodict' in 'pyproject.toml'.
  • Ensured these dependencies are not installed unintentionally with 'pip install instructor'.
  • Verified that 'pip install instructor[anthropic]' installs these dependencies without issues.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 32d17e0
  • Looked at 21 lines of code in 1 files
  • Took 25 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 85%.
1. pyproject.toml:25:
  • Assessed confidence : 0%
  • Comment:
    The optional dependencies 'anthropic' and 'xmltodict' have been added correctly to the 'tool.poetry.dependencies' and 'tool.poetry.extras' sections. This should allow users to install these dependencies optionally using the command 'pip install instructor[anthropic]'.
  • Reasoning:
    The changes in the PR seem to be in line with the intent of the author. The optional dependencies 'anthropic' and 'xmltodict' have been added correctly to the 'tool.poetry.dependencies' section and the 'tool.poetry.extras' section. This should allow users to install these dependencies optionally using the command 'pip install instructor[anthropic]'. There doesn't seem to be any violation of best practices, logical bugs, performance bugs, or security bugs. However, I will check the rest of the codebase to ensure that these changes do not affect other parts of the code.

Workflow ID: wflow_YyChmITHq1Fyt3N0


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@jxnl jxnl merged commit 496a6de into instructor-ai:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor 0.6.6 - ModuleNotFoundError: No module named 'anthropic'
2 participants