Add from_groq support #556 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 5ef728a
- Looked at
266lines of code in6files - Took 1 minute and 25 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of85%.
Workflow ID: wflow_MVHeThAaWsnvjCWt
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
PrathamSoni
pushed a commit
to EndexAI/instructor
that referenced
this pull request
Apr 10, 2024
Co-authored-by: m. rabelink <m.rabelink@belastingdienst.nl> Co-authored-by: Jason Liu <jason@jxnl.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a from_groq instead of the from_openai used in this https://python.useinstructor.com/hub/groq/#groq-ai link.
Also added two examples under examples/groq with the names: groq_example.py and groq_example2.py. The examples also show the expected output I got during testing. I also added groq.md under docs/examples with a small description.
Summary:
This PR adds support for Groq in the Instructor library, including a new
from_groqfunction, two example scripts, and a new documentation page.Key points:
from_groqfunction ininstructor/client.pyandinstructor/__init__.pygroq_example.pyandgroq_example2.pyunderexamples/groqgroq.mdunderdocs/examplesdocs/examples/index.mdto include the new documentation pageGenerated with ❤️ by ellipsis.dev