-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Partial jiter #563
Merged
Merged
feat: Partial jiter #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying instructor with
|
Latest commit: |
1a7ed5e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0104fb55.instructor.pages.dev |
Branch Preview URL: | https://partial-jiter.instructor.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Reviewed the entire pull request up to 6e12d3c
- Looked at
982
lines of code in6
files - Took 2 minutes and 43 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
3
additional comments because they didn't meet confidence threshold of85%
.
1. pyproject.toml:60
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The PR introduces a new dependency 'groq'. Please provide a justification for adding this new dependency. It's important to understand its purpose and ensure it doesn't introduce potential security vulnerabilities or conflicts with existing dependencies. - Reasoning:
The PR introduces a new dependency 'groq' in the 'pyproject.toml' file. However, there is no clear explanation in the PR description about why this new dependency is needed. It's important to understand the purpose of adding a new dependency to ensure it's necessary and doesn't introduce potential security vulnerabilities or conflicts with existing dependencies.
2. examples/partial_streaming/benchmark.py:59
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The PR changes the 'response_model' from 'PartialUser' to 'User'. Please ensure that the 'User' model has the same structure or properties as the 'PartialUser' model to avoid potential issues. - Reasoning:
The PR changes the 'response_model' from 'PartialUser' to 'User' in the 'benchmark_partial_streaming' function. This could potentially impact the functionality of the function if the 'User' model doesn't have the same structure or properties as the 'PartialUser' model. I need to check the definitions of these two models to ensure they are compatible.
3. poetry.lock:325
:
- Assessed confidence :
100%
- Grade:
20%
- Comment:
The PR introduces several new dependencies. Please provide a justification for adding these new dependencies. It's important to understand their purpose and ensure they don't introduce potential security vulnerabilities or conflicts with existing dependencies. - Reasoning:
The PR introduces several new dependencies in the 'poetry.lock' file. However, there is no clear explanation in the PR description about why these new dependencies are needed. It's important to understand the purpose of adding new dependencies to ensure they're necessary and don't introduce potential security vulnerabilities or conflicts with existing dependencies.
Workflow ID: wflow_vgS6ktBJvSp2kt8E
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
PrathamSoni
pushed a commit
to EndexAI/instructor
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces 'Partial jiter', modifies the
benchmark_partial_streaming
function, removesinstructor/dsl/partialjson.py
, updatespoetry.lock
with new dependencies, and addspydantic-core
andgroq
topyproject.toml
.Key points:
benchmark_partial_streaming
function inexamples/partial_streaming/benchmark.py
.instructor/dsl/partialjson.py
.poetry.lock
with new dependencies.pydantic-core
topyproject.toml
.groq
topyproject.toml
.Generated with ❤️ by ellipsis.dev