Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Partial jiter #563

Merged
merged 3 commits into from
Apr 4, 2024
Merged

feat: Partial jiter #563

merged 3 commits into from
Apr 4, 2024

Conversation

jxnl
Copy link
Collaborator

@jxnl jxnl commented Apr 4, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit 6e12d3c.

Summary:

This PR introduces 'Partial jiter', modifies the benchmark_partial_streaming function, removes instructor/dsl/partialjson.py, updates poetry.lock with new dependencies, and adds pydantic-core and groq to pyproject.toml.

Key points:

  • Modified benchmark_partial_streaming function in examples/partial_streaming/benchmark.py.
  • Removed instructor/dsl/partialjson.py.
  • Updated poetry.lock with new dependencies.
  • Added pydantic-core to pyproject.toml.
  • Added new optional dependency groq to pyproject.toml.

Generated with ❤️ by ellipsis.dev

@jxnl jxnl marked this pull request as ready for review April 4, 2024 00:11
Copy link

cloudflare-workers-and-pages bot commented Apr 4, 2024

Deploying instructor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a7ed5e
Status: ✅  Deploy successful!
Preview URL: https://0104fb55.instructor.pages.dev
Branch Preview URL: https://partial-jiter.instructor.pages.dev

View logs

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 4, 2024
@jxnl jxnl merged commit 06e309d into main Apr 4, 2024
1 check was pending
@jxnl jxnl deleted the partial-jiter branch April 4, 2024 00:11
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 6e12d3c
  • Looked at 982 lines of code in 6 files
  • Took 2 minutes and 43 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 3 additional comments because they didn't meet confidence threshold of 85%.
1. pyproject.toml:60:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The PR introduces a new dependency 'groq'. Please provide a justification for adding this new dependency. It's important to understand its purpose and ensure it doesn't introduce potential security vulnerabilities or conflicts with existing dependencies.
  • Reasoning:
    The PR introduces a new dependency 'groq' in the 'pyproject.toml' file. However, there is no clear explanation in the PR description about why this new dependency is needed. It's important to understand the purpose of adding a new dependency to ensure it's necessary and doesn't introduce potential security vulnerabilities or conflicts with existing dependencies.
2. examples/partial_streaming/benchmark.py:59:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The PR changes the 'response_model' from 'PartialUser' to 'User'. Please ensure that the 'User' model has the same structure or properties as the 'PartialUser' model to avoid potential issues.
  • Reasoning:
    The PR changes the 'response_model' from 'PartialUser' to 'User' in the 'benchmark_partial_streaming' function. This could potentially impact the functionality of the function if the 'User' model doesn't have the same structure or properties as the 'PartialUser' model. I need to check the definitions of these two models to ensure they are compatible.
3. poetry.lock:325:
  • Assessed confidence : 100%
  • Grade: 20%
  • Comment:
    The PR introduces several new dependencies. Please provide a justification for adding these new dependencies. It's important to understand their purpose and ensure they don't introduce potential security vulnerabilities or conflicts with existing dependencies.
  • Reasoning:
    The PR introduces several new dependencies in the 'poetry.lock' file. However, there is no clear explanation in the PR description about why these new dependencies are needed. It's important to understand the purpose of adding new dependencies to ensure they're necessary and don't introduce potential security vulnerabilities or conflicts with existing dependencies.

Workflow ID: wflow_vgS6ktBJvSp2kt8E


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

PrathamSoni pushed a commit to EndexAI/instructor that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant