Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple groups and versions for a kind #63

Conversation

johanneswuerbach
Copy link
Contributor

A kind can exist in multiple groups and versions in different shapes.

Requires instrumenta/openapi2jsonschema#11 and to re-generate all schemas similar to garethr/kubernetes-json-schema#4

Fixes #57

A kind can exist in multiple groups and versions in different shapes.

Fixes instrumenta#57
@garethr
Copy link
Collaborator

garethr commented Mar 24, 2018

@johanneswuerbach thanks for taking a run at this. I'll make some time to review as soon as I can. Much appreciated.

@petemounce
Copy link

I'm affected by the problem that this aims to address as well. Thanks very much for proposing the change!

@johanneswuerbach
Copy link
Contributor Author

@garethr friendly ping, anyway I could help?

@garethr
Copy link
Collaborator

garethr commented Apr 5, 2019

Just to say I've finally got time to work on this and am in the process of publishing updated schemas. The main thing I'm looking to do is avoid breaking existing installs so it will take a little time to roll out. But the work in this PR looks good. Thanks again.

@garethr
Copy link
Collaborator

garethr commented Apr 16, 2019

Thanks @johanneswuerbach. I've got a modified version of this merged in to 0.8.0 and released. Thanks for doing a bunch of the work on that change, much appreciated.

@garethr garethr closed this Apr 16, 2019
@johanneswuerbach
Copy link
Contributor Author

Thank you @garethr for making the tool in the first place 🙇 and happy to help.

With 0.8.0 I get a bunch of issues when trying to validate against 1.10, should I create a new issue around that?

12 errors occurred:
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrole-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrole-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrole-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrole-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrolebinding-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrolebinding-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrolebinding-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrole-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrolebinding-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrolebinding-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrole-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found
	* Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.10.9-standalone-strict/clusterrolebinding-rbac.authorization.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found

@ghost
Copy link

ghost commented Apr 16, 2019

I got a similar error with 0.8.0:

1 error occurred:
        * Problem loading schema from the network at https://kubernetesjsonschema.dev/v1.9.3-standalone/storageclass-storage.k8s.io-v1.json: Could not read schema from HTTP, response status is 404 Not Found

It's that .k8s.io is appended to the end of the resource kind.

👎: https://kubernetesjsonschema.dev/v1.9.3-standalone/storageclass-storage.k8s.io-v1.json

👍: https://kubernetesjsonschema.dev/v1.9.3-standalone/storageclass-storage-v1.json

@garethr
Copy link
Collaborator

garethr commented Apr 16, 2019

@jb-sean @johanneswuerbach thanks. Should be fixed in acbe515. This should be published as 0.8.1 a just a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XXXX.yaml contains an invalid HorizontalPodAutoscaler
3 participants