-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple groups and versions for a kind #63
Support multiple groups and versions for a kind #63
Conversation
A kind can exist in multiple groups and versions in different shapes. Fixes instrumenta#57
@johanneswuerbach thanks for taking a run at this. I'll make some time to review as soon as I can. Much appreciated. |
I'm affected by the problem that this aims to address as well. Thanks very much for proposing the change! |
@garethr friendly ping, anyway I could help? |
Just to say I've finally got time to work on this and am in the process of publishing updated schemas. The main thing I'm looking to do is avoid breaking existing installs so it will take a little time to roll out. But the work in this PR looks good. Thanks again. |
Thanks @johanneswuerbach. I've got a modified version of this merged in to 0.8.0 and released. Thanks for doing a bunch of the work on that change, much appreciated. |
Thank you @garethr for making the tool in the first place 🙇 and happy to help. With 0.8.0 I get a bunch of issues when trying to validate against 1.10, should I create a new issue around that?
|
I got a similar error with 0.8.0:
It's that 👎: https://kubernetesjsonschema.dev/v1.9.3-standalone/storageclass-storage.k8s.io-v1.json 👍: https://kubernetesjsonschema.dev/v1.9.3-standalone/storageclass-storage-v1.json |
@jb-sean @johanneswuerbach thanks. Should be fixed in acbe515. This should be published as 0.8.1 a just a moment. |
A kind can exist in multiple groups and versions in different shapes.
Requires instrumenta/openapi2jsonschema#11 and to re-generate all schemas similar to garethr/kubernetes-json-schema#4
Fixes #57