This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdokimovs
added
enhancement
Improvement of existing features or bugfix
k::testing
Related to testing and/or automated tests
labels
Oct 8, 2019
FCM
|
Для этого PR нужно будет опубликовать instrumentisto/geckodriver-docker-image на Docker Hub под именем Также желательно все же прогнать CI после публикации |
alexlapa
approved these changes
Oct 9, 2019
Docker image is released: https://hub.docker.com/r/instrumentisto/geckodriver |
tyranron
force-pushed
the
dockerize-browser-jason-testing
branch
from
October 9, 2019 10:04
bfc6524
to
0478289
Compare
tyranron
force-pushed
the
dockerize-browser-jason-testing
branch
from
October 9, 2019 10:05
0478289
to
90bd92f
Compare
tyranron
approved these changes
Oct 9, 2019
evdokimovs
changed the title
WIP: Dockerize Jason's browser unit testing
Dockerize Jason's browser unit testing
Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Improvement of existing features or bugfix
k::testing
Related to testing and/or automated tests
k::toolchain
Related to project toolchain
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27
Required for #33
Synopsis
Because rustwasm/wasm-bindgen#1744 done we may use remote webdriver for Jason unit tests.
For Chrome we will use selenoid/chrome Docker image.
For Firefox was decided to wrote own Dockerfile and use it. This image will be available as instrumentisto/geckodriver on Docker Hub. Source codes for this image you can find in instrumentisto/geckodriver-docker-image repo. Due to this Dockerfile we can use any version of Firefox (just build it with needed build-arg and publish to Docker Hub).
Solution
webdriver.conf
with needed prefsCHROMEDRIVER_CLIENT_ARGS
from.env
Checklist
WIP:
prefixk::
labels appliedWIP:
prefix is removed