Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Dockerize Jason's browser unit testing #56

Merged
merged 10 commits into from
Oct 9, 2019

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 8, 2019

Part of #27

Required for #33

Synopsis

Because rustwasm/wasm-bindgen#1744 done we may use remote webdriver for Jason unit tests.

For Chrome we will use selenoid/chrome Docker image.

For Firefox was decided to wrote own Dockerfile and use it. This image will be available as instrumentisto/geckodriver on Docker Hub. Source codes for this image you can find in instrumentisto/geckodriver-docker-image repo. Due to this Dockerfile we can use any version of Firefox (just build it with needed build-arg and publish to Docker Hub).

Solution

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests labels Oct 8, 2019
@evdokimovs evdokimovs added this to the 0.2.0 milestone Oct 8, 2019
@evdokimovs evdokimovs self-assigned this Oct 8, 2019
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Oct 8, 2019

FCM

Dockerize Jason unit testing and add Firefox support (#56)

- create webdriver.json with Chrome and Firefox WebDriver preferences
- delete outdated CHROMEDRIVER_CLIENT_ARGS env var from .env file
- add Makefile commands to boot up dockerized WebDriver and run tests
- update Travis CI spec to run Jason unit tests in dockerized Chrome and Firefox

Additionally:
- use stable Rust for Jason tests in Travis CI

@evdokimovs
Copy link
Contributor Author

@tyranron , @alexlapa ,

Для этого PR нужно будет опубликовать instrumentisto/geckodriver-docker-image на Docker Hub под именем instrumentisto/geckodriver. На данный момент в Makefile используется образ с instrumentisto/geckodriver, поэтому тесты не будут проходить. Если захотите прогнать их до публикации от имени instrumentisto, то можете заменить instrumentisto/geckodriver на alexlapa/geckodriver.

Также желательно все же прогнать CI после публикации instrumentisto/geckodriver, чтобы убедиться, что все работает.

@evdokimovs evdokimovs marked this pull request as ready for review October 8, 2019 17:10
@evdokimovs evdokimovs requested a review from alexlapa October 8, 2019 17:11
@alexlapa alexlapa requested a review from tyranron October 9, 2019 00:35
@tyranron
Copy link
Member

tyranron commented Oct 9, 2019

Docker image is released: https://hub.docker.com/r/instrumentisto/geckodriver

@tyranron tyranron force-pushed the dockerize-browser-jason-testing branch from bfc6524 to 0478289 Compare October 9, 2019 10:04
@tyranron tyranron force-pushed the dockerize-browser-jason-testing branch from 0478289 to 90bd92f Compare October 9, 2019 10:05
@evdokimovs evdokimovs changed the title WIP: Dockerize Jason's browser unit testing Dockerize Jason's browser unit testing Oct 9, 2019
@evdokimovs evdokimovs merged commit 7fea8be into master Oct 9, 2019
@evdokimovs evdokimovs deleted the dockerize-browser-jason-testing branch October 9, 2019 11:31
@tyranron tyranron added the k::toolchain Related to project toolchain label Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants