Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #501

Merged
merged 15 commits into from
Aug 22, 2022
Merged

Cleanup #501

merged 15 commits into from
Aug 22, 2022

Conversation

oliche
Copy link
Member

@oliche oliche commented Aug 12, 2022

Some modules functions are removed

@k1o0
Copy link
Contributor

k1o0 commented Aug 12, 2022

Although the tests pass there are problems with the log. Each call to the ibllib logger leads to an exception about logging to a closed file. The handler in question is probably the one added by runAllTests. I jinx'd everything by saying I was happy with the CI server haha. The log is too big to load remotely so here's one of the errors:

--- Logging error ---
Traceback (most recent call last):
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/logging/__init__.py", line 1088, in emit
    stream.write(msg + self.terminator)
ValueError: I/O operation on closed file
Call stack:
  File "/home/experiment/anaconda3/envs/ci/bin/coverage", line 8, in <module>
    sys.exit(main())
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/site-packages/coverage/cmdline.py", line 943, in main
    status = CoverageScript().command_line(argv)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/site-packages/coverage/cmdline.py", line 659, in command_line
    return self.do_run(options, args)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/site-packages/coverage/cmdline.py", line 830, in do_run
    runner.run()
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/site-packages/coverage/execfile.py", line 199, in run
    exec(code, main_mod.__dict__)
  File "/home/experiment/Documents/github/ibllib-repo/../iblscripts/runAllTests.py", line 133, in <module>
    result, test_list = run_tests(dry_run=args.dry_run)
  File "/home/experiment/Documents/github/ibllib-repo/../iblscripts/runAllTests.py", line 88, in run_tests
    result = unittest.TextTestRunner(verbosity=2, stream=sys.stdout).run(ci_tests)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/runner.py", line 176, in run
    test(result)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/suite.py", line 84, in __call__
    return self.run(*args, **kwds)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/suite.py", line 122, in run
    test(result)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/suite.py", line 84, in __call__
    return self.run(*args, **kwds)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/suite.py", line 122, in run
    test(result)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/suite.py", line 84, in __call__
    return self.run(*args, **kwds)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/suite.py", line 122, in run
    test(result)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/case.py", line 736, in __call__
    return self.run(*args, **kwds)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/unittest/mock.py", line 1325, in patched
    return func(*newargs, **newkeywargs)
  File "/home/experiment/Documents/github/iblscripts/ci/tests/test_camera_extraction.py", line 697, in test_ephys
    jobqc.run()
  File "/home/experiment/anaconda3/envs/ci/lib/python3.8/site-packages/ibllib/pipes/tasks.py", line 103, in run
    _logger.info(f"running ibllib version {ibllib.__version__}")
Message: 'running ibllib version 2.13.6'
Arguments: ()
--- Logging error ---

I'll re-trigger the tests and let's see if it was a one-time thing.

@oliche oliche closed this Aug 22, 2022
@oliche oliche reopened this Aug 22, 2022
@oliche oliche merged commit c4cbbc0 into develop Aug 22, 2022
@oliche oliche deleted the cleanup branch August 22, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants