Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from kubebuilder v4.0.0 to v4.1.1 #1128

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

int128
Copy link
Owner

@int128 int128 commented Aug 15, 2024

Copy link
Contributor

github-actions bot commented Aug 15, 2024

diff

  • config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-auth-role.yaml (New)
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-reader.yaml (New)
  • config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_argocd-commenter-metrics-auth-rolebinding.yaml (New)
  • config/default/v1_service_argocd-commenter-controller-manager-metrics-service.yaml (New)
  • e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml
  • e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-auth-role.yaml (New)
  • e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-reader.yaml (New)
  • e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrolebinding_argocd-commenter-metrics-auth-rolebinding.yaml (New)
  • e2e_test/controller/v1_service_argocd-commenter-controller-manager-metrics-service.yaml (New)

config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml

--- a/tmp/kustomize-action-XXXXXXe0YDwp/config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml
@@ -19,6 +19,7 @@ spec:
     spec:
       containers:
       - args:
+        - --metrics-bind-address=:8443
         - --leader-elect
         - --health-probe-bind-address=:8081
         command:

config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-auth-role.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-auth-role.yaml
@@ -0,0 +1,17 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: argocd-commenter-metrics-auth-role
+rules:
+- apiGroups:
+  - authentication.k8s.io
+  resources:
+  - tokenreviews
+  verbs:
+  - create
+- apiGroups:
+  - authorization.k8s.io
+  resources:
+  - subjectaccessreviews
+  verbs:
+  - create

config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-reader.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-reader.yaml
@@ -0,0 +1,9 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: argocd-commenter-metrics-reader
+rules:
+- nonResourceURLs:
+  - /metrics
+  verbs:
+  - get

config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_argocd-commenter-metrics-auth-rolebinding.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_argocd-commenter-metrics-auth-rolebinding.yaml
@@ -0,0 +1,12 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: argocd-commenter-metrics-auth-rolebinding
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: argocd-commenter-metrics-auth-role
+subjects:
+- kind: ServiceAccount
+  name: argocd-commenter-controller-manager
+  namespace: argocd-commenter-system

config/default/v1_service_argocd-commenter-controller-manager-metrics-service.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/config/default/v1_service_argocd-commenter-controller-manager-metrics-service.yaml
@@ -0,0 +1,17 @@
+apiVersion: v1
+kind: Service
+metadata:
+  labels:
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: argocd-commenter
+    control-plane: controller-manager
+  name: argocd-commenter-controller-manager-metrics-service
+  namespace: argocd-commenter-system
+spec:
+  ports:
+  - name: https
+    port: 8443
+    protocol: TCP
+    targetPort: 8443
+  selector:
+    control-plane: controller-manager

e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml

--- a/tmp/kustomize-action-XXXXXXe0YDwp/e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml
@@ -19,6 +19,7 @@ spec:
     spec:
       containers:
       - args:
+        - --metrics-bind-address=:8443
         - --leader-elect
         - --health-probe-bind-address=:8081
         command:

e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-auth-role.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-auth-role.yaml
@@ -0,0 +1,17 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: argocd-commenter-metrics-auth-role
+rules:
+- apiGroups:
+  - authentication.k8s.io
+  resources:
+  - tokenreviews
+  verbs:
+  - create
+- apiGroups:
+  - authorization.k8s.io
+  resources:
+  - subjectaccessreviews
+  verbs:
+  - create

e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-reader.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-metrics-reader.yaml
@@ -0,0 +1,9 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: argocd-commenter-metrics-reader
+rules:
+- nonResourceURLs:
+  - /metrics
+  verbs:
+  - get

e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrolebinding_argocd-commenter-metrics-auth-rolebinding.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrolebinding_argocd-commenter-metrics-auth-rolebinding.yaml
@@ -0,0 +1,12 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: argocd-commenter-metrics-auth-rolebinding
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: argocd-commenter-metrics-auth-role
+subjects:
+- kind: ServiceAccount
+  name: argocd-commenter-controller-manager
+  namespace: argocd-commenter-system

e2e_test/controller/v1_service_argocd-commenter-controller-manager-metrics-service.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXRJEY0v/e2e_test/controller/v1_service_argocd-commenter-controller-manager-metrics-service.yaml
@@ -0,0 +1,17 @@
+apiVersion: v1
+kind: Service
+metadata:
+  labels:
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: argocd-commenter
+    control-plane: controller-manager
+  name: argocd-commenter-controller-manager-metrics-service
+  namespace: argocd-commenter-system
+spec:
+  ports:
+  - name: https
+    port: 8443
+    protocol: TCP
+    targetPort: 8443
+  selector:
+    control-plane: controller-manager

See the workflow run

@int128 int128 changed the title Upgrade from kubebuilder v4.0.0 to v4.1.0 Upgrade from kubebuilder v4.0.0 to v4.1.1 Aug 15, 2024
@int128 int128 marked this pull request as ready for review August 15, 2024 09:14
@int128 int128 merged commit 31f4fe2 into main Aug 15, 2024
17 checks passed
@int128 int128 deleted the upgrade-kubebuilder-v4.1.0 branch August 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant