Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESM #746

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Migrate to ESM #746

merged 1 commit into from
Apr 21, 2024

Conversation

int128
Copy link
Owner

@int128 int128 commented Apr 21, 2024

Copy link
Contributor

diff

  • bar.txt (New)
  • foo.txt (Deleted)
  • rollout.yaml
  • service.yaml

bar.txt

--- /dev/null
+++ b/tests/fixtures/head/bar.txt
@@ -0,0 +1 @@
+New file.

foo.txt

--- a/tests/fixtures/base/foo.txt
+++ /dev/null
@@ -1 +0,0 @@
-This file will be deleted.

rollout.yaml

--- a/tests/fixtures/base/deployment.yaml
+++ b/tests/fixtures/head/rollout.yaml
@@ -1,5 +1,5 @@
-apiVersion: apps/v1
-kind: Deployment
+apiVersion: argoproj.io/v1alpha1
+kind: Rollout
 metadata:
   name: envoy
 spec:
@@ -13,4 +13,8 @@ spec:
         app.kubernetes.io/name: envoy
     spec:
       containers:
-        - image: envoyproxy/envoy:v1.17-latest
+        - image: envoyproxy/envoy:v1.18-latest
+  strategy:
+    canary:
+      maxUnavailable: 0
+      maxSurge: 1

service.yaml

--- a/tests/fixtures/base/service.yaml
+++ b/tests/fixtures/head/service.yaml
@@ -7,5 +7,5 @@ spec:
       app.kubernetes.io/name: echoserver
   ports:
   - protocol: TCP
-    port: 80
-    targetPort: 80
+    port: 443
+    targetPort: 443

See the workflow run

@github-actions github-actions bot added changed and removed changed labels Apr 21, 2024
@int128 int128 merged commit df9210a into main Apr 21, 2024
2 checks passed
@int128 int128 deleted the migrate-esm branch April 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant