Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post no diff comment and change default strategy to replace #814

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

int128
Copy link
Owner

@int128 int128 commented Jul 20, 2024

Problem to solve

Currently, this action does not post a comment if no diff. A reviewer needs to see the workflow log to check if the pull request causes no diff.

How to solve

Change the behavior as follows:

  • Even if no diff, post a comment.
  • Change the default comment strategy to "replace". This prevents the comment flood.

Copy link
Contributor

github-actions bot commented Jul 20, 2024

diff

No diff

See the workflow run

@github-actions github-actions bot added changed and removed changed labels Jul 20, 2024
@int128 int128 changed the title Replace comment by default Post no diff comment and change default strategy to replace Jul 20, 2024
@github-actions github-actions bot added changed and removed changed labels Jul 20, 2024
@int128 int128 marked this pull request as ready for review July 20, 2024 04:37
@int128 int128 merged commit 5792360 into main Jul 20, 2024
2 checks passed
@int128 int128 deleted the int128/Replace-comment-by-default branch July 20, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant