Use RUNNER_TEMP instead of os.tmpdir #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int128
commented
Jan 1, 2023
| const args = generateArgs(inputs, outputDir) | ||
| const runnerTempDir = process.env.RUNNER_TEMP || os.tmpdir() | ||
| const outputsDir = await fs.mkdtemp(path.join(runnerTempDir, 'kaniko-action-')) | ||
| const args = generateArgs(inputs, outputsDir) |
There was a problem hiding this comment.
For GitHub-hosted runners,
/usr/bin/docker run --rm
-v /home/runner/work/kaniko-action/kaniko-action/tests/fixtures:/kaniko/action/context:ro
-v /home/runner/work/_temp/kaniko-action-176zzr:/kaniko/action/outputs
-v /home/runner/.docker/:/kaniko/.docker/:ro
-e container=docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may resolve the issue #347.
As actions/toolkit#518, it would be preferred to use
RUNNER_TEMPfor security. Also better for self-hosted runners, becauseRUNNER_TEMPmay be mountable from a separated Docker container.