Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init #1

Merged
merged 7 commits into from
Feb 21, 2019
Merged

Init #1

merged 7 commits into from
Feb 21, 2019

Conversation

odra
Copy link
Contributor

@odra odra commented Feb 20, 2019

Initial commit, contains the basic structure of container scripts, container source code and openshift templates.

Instructions can be found in the readme file.

There is no backup code logic yet, this PR is supposed to build the base structure for the actual work which will be handled in other PRs/Tickets.

Note: The required secret objects would be created in the installer so those templates are highly configurable.

image/README.md Outdated Show resolved Hide resolved
required: true
- name: CRON_SCHEDULE
description: 'Job schedule in Cron Format [Default is everyday at 2am]'
value: '*/1 * * * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description above("[Default is everyday at 2am]") doesn't match this value.

Copy link
Contributor

@matskiv matskiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the templates and docker build, it seems to work 👍

Looks good besides one comment above.

@odra odra merged commit 1c0d3f9 into integr8ly:master Feb 21, 2019
@@ -0,0 +1,20 @@
FROM centos:7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use rhel here instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need RHEL host with subscription to build it. So we would need to build in private jenkins instance.

matskiv added a commit that referenced this pull request Jan 14, 2020
Ignore jwtproxy pods in codeready pv backup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants