INTLY-1493 - Add parameter for namespace prefix #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I built and pushed current state to |
|
This was originally based on stale master. Rebased, rebuilt, pushed. |
matskiv
changed the title
|
👀 |
aidenkeating
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.jboss.org/browse/INTLY-1493
Verification
Create backup jobs via installer with this additional params -
-e 'backup_schedule="*/1 * * * *"' -e backup_image=quay.io/integreatly/backup-container:devOnce the jobs are created, edit cronjobs that are affected by this PR (3scale-redis-backup, codeready-pv-backup and enmasse-pv-backup) add new env var with correct NS prefix:
Wait until the jobs get triggered and check the result of those three jobs.
Redis job should successfully back up .rdb file.
Codeready might show a warning about not finding any workspaces (optional: create one and wait until next job is triggered)
Enmasse pv cronjob might show this error if you have no data in enmasse:
ls: cannot access /tmp/enmasse-data/*: No such file or directorythat is okay.