fix bash syntax and error handling

[odra]

• fixes error handing
• use posix compliant conditional syntax

[jessesarn]

Looks good

[maleck13]

We will need an upgrade for this in the 1.4 upgrade playbook
Do we also need a change to installation to use this image?

[matskiv]

Yeah, good point about the upgrade 👍
Maybe we can write something generic, that will update backup image version on each upgrade, so we don't have to do it each release?

PR looks good to me, I am building the image now, and testing it on my cluster in a moment.

[maleck13]

Ok lets create a follow up for the upgrade piece and then get this merged and cherry-picked to the 1.4 branch

[matskiv]

I finished the testing. Everything works(and fails) as expected.
This improvement actually helped to uncover an issue with 3Scale 2.5 postgresql backup - https://issues.jboss.org/browse/INTLY-2023

We will have to do a new release of backup image, and bump version in the installer.

[matskiv]

I finished testing. Everything works(and fails) as expected. 👍

Improvement from this PR actually helped uncover another issue - https://issues.jboss.org/browse/INTLY-2023

For both installation and upgrade, we will have to do a new release of the backup image, and then bump the version in the installer

[odra]

does it need a cherry pick into the 1.4 branch?

[maleck13]

yes also needs a follow up to deal with the upgrade