Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pv checks #39

Merged
merged 1 commit into from
May 9, 2019
Merged

fix pv checks #39

merged 1 commit into from
May 9, 2019

Conversation

odra
Copy link
Contributor

@odra odra commented May 9, 2019

exits on pv components if there is no data to be dumped

@odra odra requested a review from matskiv May 9, 2019 15:01
local pods="$(oc get pods -n ${PRODUCT_NAMESPACE_PREFIX}codeready | grep workspace)"
if [ "${#pods}" -eq "0" ]; then
echo "=>> No workspaces found to backup"
exit 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldnt find a better way to handle this in the entrypoint file so I decided to exit here

@matskiv
Copy link
Member

matskiv commented May 9, 2019

I'll test this on my cluster now.

Copy link
Member

@matskiv matskiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and verified. 👍

@odra odra merged commit 82901a8 into integr8ly:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants