adapt error handling #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odra
reviewed
May 15, 2019
| @@ -13,7 +13,7 @@ function check_resource { | |||
| # was returned but no actual results. That would be at | |||
| # least two lines: one for the header and one for each | |||
| # resource found | |||
| if [ "$result" -eq "1" ]; then | |||
| if [[ "$result" -eq "1" ]]; then | |||
There was a problem hiding this comment.
any reason you had to change it?
There was a problem hiding this comment.
My IDE suggests this, no immediate reason though
There was a problem hiding this comment.
The previous way (one []) is posix standard which enables people with non linux machines to run those scripts locally (such as macs) - could you please revert it to the old way?
odra
reviewed
May 15, 2019
odra
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resources script has a few conflicts with the new error handling:
-eo pipefailoption set. So for this function those options are temporarily unset.