Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codeready pv archive fn #43

Merged
merged 1 commit into from
May 21, 2019

Conversation

odra
Copy link
Contributor

@odra odra commented May 20, 2019

Verification

  • Build the image yourself or use docker.io/odranoel/backup-container:dev
  • edit coderedy pv cronjob do use the above image: oc edit cronjob/codeready-pv-backup -n openshift-integreatly-backups
  • Run a job from the cronjob: oc create job jobname --from=cronjob/codeready-pv-backup -n openshift-integreatly-backups
  • Check if job was successfull
  • Download the archive from s3 and check if all workspaces were properly archived

@odra odra requested a review from trepel May 20, 2019 16:13
@trepel
Copy link
Member

trepel commented May 21, 2019

Reviewing

Copy link
Member

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I followed the verification steps (even created my own image in docker.io) and the backup job indeed backed up all the workspaces. Merging.

@trepel trepel merged commit 2950d35 into integr8ly:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants