Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend redis bgsave #47

Merged
merged 1 commit into from
May 30, 2019
Merged

backend redis bgsave #47

merged 1 commit into from
May 30, 2019

Conversation

odra
Copy link
Contributor

@odra odra commented May 30, 2019

Verification

  • Build the image
  • Create a secret named 3scale-redis-secret that contains a field REDIS_HOST which points to the 3scale backend redis service host
  • Edit the redis cronjob to use the new redis secret
  • Create a job from the cronjob: oc create job redistmp --from=cronjob/3scale-redis-backup
  • Check the job pod logs to see if it worked as expected

@odra odra mentioned this pull request May 30, 2019
Merged
3 tasks
@odra odra requested review from matskiv and pb82 May 30, 2019 08:44
JameelB
JameelB approved these changes May 30, 2019
View reviewed changes
Copy link

@JameelB JameelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on PDS

@odra odra merged commit f4e1e20 into integr8ly:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JameelB JameelB JameelB approved these changes

@matskiv matskiv Awaiting requested review from matskiv

@pb82 pb82 Awaiting requested review from pb82

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odra @JameelB