Allow defining product namespace instead of prefix #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matskiv
force-pushed
the
allow-product-namespace
branch
from
fa2988d
to
c68b95d
Compare
Ignore jwtproxy pods in codeready pv backup
|
Spinning up a 3.x cluster and will attempt to verify the PR on that cluster |
|
@matskiv can confirm backup jobs run successfully on a 3.x cluster - but seeing an issue with the This may have been broken before your PR I suspect |
|
@damienomurchu yeah, that might have been already broken. I will add a commit with a fix and rebuild the image (quay.io/omatskiv/backup-container:latest). |
|
Turns out api server in |
damienomurchu
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is added to allow setting product namespace name directly, instead of relying on hard-coded suffix values.
Motivation: on 4.x we use "amq-online" ns name instead of enmasse.
Second change is for CodeReady workspaces backup - improved filtering of the pods, to avoid matching an OLM pod ("registry-cs-rhmi-codeready-workspaces-w8kjm").
This should be backwards compatible with 1.x, but that needs to be thoroughly tested.