Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crw 2.0 requires backing up non-default container inside a pod #58

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

pb82
Copy link
Contributor

@pb82 pb82 commented Jun 25, 2020

Implement container backup that backs up every container inside a pod. This has become necessary since CRW 2.0 because the projects directory is no longer in the default container.

Verification steps:

  1. Get a cluster with RHMI installed
  2. In the redhat-rhmi-codeready-workspaces namespace edit the cronjob for creating PV backups: oc edit cronjobs codeready-pv-backup
  3. Replace the backup image with quay.io/pb82/backup-container-image:latest
  4. Make sure that a workspace pod in CRW exists. If not open CRW and create a workspace.
  5. Launch a backup job manually: oc create job codeready-pv-backup-$(date +"%Y-%m-%d-%H%M%S") --from=cronjob/codeready-pv-backup -n redhat-rhmi-codeready-workspaces
  6. Check the logs of the backup pod and make sure workspace files are actually backed up: oc logs <backup pod name>

@sergioifg94
Copy link
Contributor

Code looks good to me, and verified it on a cluster
/lgtm

@pb82 pb82 merged commit 2fa27ce into integr8ly:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants