This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
[WIP] Use oc create in fuse managed instead of apply #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenkeating
requested review from
david-martin,
JameelB,
maleck13,
matskiv,
mikenairn,
odra,
pb82,
philbrookes,
pmccarthy,
sedroche,
tremes and
trepel
as code owners
sedroche
reviewed
Mar 27, 2019
roles/fuse_managed/tasks/main.yml
Outdated
|
|
||
| - name: Verify Fuse deployment succeeded | ||
| shell: oc get pods -n {{ fuse_namespace }} --selector="app=syndesis" -o jsonpath='{.items[*].status.containerStatuses[?(@.ready==true)].ready}' | wc -w | ||
| shell: oc get pods -n openshift-fuse -o jsonpath='{.items[*].status.containerStatuses[?(@.ready==true)].ready}' | wc -w | tr -d ' ' |
There was a problem hiding this comment.
Are you going for {{ns_prefix}}{{ fuse_namespace }} here?
Currently, we are using `oc apply` in many places in the Fuse
Managed installation. This causes issues when running the installation
over an existing installation as `oc apply` will update the existing
resources.
This change changes these places to `oc create` with a check that will
not fail if the resource already exists.
This change also includes an update to the Fuse Managed checks to see
if all Pods are up. Instead of referencing a label and specifying an
exact number of Pods, this will now specify a minimum amount of Pods
that should exist in the namespace before continuing.
Verification:
- Run the installer
- Ensure it completes successfully
- Ensure the console can be accessed by any two users in the
cluster, to verify the OAuth proxy rules are still correct
- Run the installer again, with the Fuse Managed namespace now
there
- Ensure it completes successfully, again
aidenkeating
force-pushed
the
fuse-managed-oc-create
branch
from
8aa579d
to
0d56914
Compare
|
@aidenkeating Update and re-open if this is still valid. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are using
oc applyin many places in the FuseManaged installation. This causes issues when running the installation
over an existing installation as
oc applywill update the existingresources.
This change changes these places to
oc createwith a check that willnot fail if the resource already exists.
This change also includes an update to the Fuse Managed checks to see
if all Pods are up. Instead of referencing a label and specifying an
exact number of Pods, this will now specify a minimum amount of Pods
that should exist in the namespace before continuing.
Verification:
cluster, to verify the OAuth proxy rules are still correct
there
Resolves #402