This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Ensure subsequent attempts of patching enmasse auth images succeeds #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JameelB
requested review from
aidenkeating,
david-martin,
maleck13,
mikenairn,
odra,
pb82,
philbrookes,
pmccarthy,
sedroche,
tremes and
trepel
as code owners
|
Closing as our target is 3.11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
Ensure attempts of patching enmasse auth images does not fail when there are no changes.
Versions of oc that are lower than
v3.11.0returns an exit code 1 when attempting to patch objects with no difference between the existing object. This is a known issue and has been fixed for3.11.Verification Steps