Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP MGDAPI-3177 wip pr for making 3scale cluster scoped #2409

Conversation

austincunningham
Copy link
Member

@austincunningham austincunningham commented Jan 19, 2022

Issue link

https://issues.redhat.com/browse/MGDAPI-3177

What

Verification steps

INSTALLATION_TYPE=managed-api make cluster/prepare/local
INSTALLATION_TYPE=managed-api USE_CLUSTER_STORAGE=false make deploy/integreatly-rhmi-cr.yml
INSTALLATION_TYPE=managed-api make code/run

After 3scale starts to provision In installed operators the scope of threescale operator will be All Namespaces e.g.

image

Test the upgrade

INSTALLATION_TYPE=managed-api make cluster/prepare/local
INSTALLATION_TYPE=managed-api USE_CLUSTER_STORAGE=true make deploy/integreatly-rhmi-cr.yml

Install the following catalogSource

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: rhmi-operators 
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/austincunningham/managed-api-service-index:1.17.0

After the install finished update the index
quay.io/austincunningham/managed-api-service-index:1.18.0

confirm the behavior is the same as the sprint demo

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pmccarthy after the PR has been reviewed.
You can assign the PR to them by writing /assign @pmccarthy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Patryk-Stefanski
Copy link
Contributor

Verification

Ran the following commands:

INSTALLATION_TYPE=managed-api make cluster/prepare/local
INSTALLATION_TYPE=managed-api USE_CLUSTER_STORAGE=true make deploy/integreatly-rhmi-cr.yml
INSTALLATION_TYPE=managed-api make code/run

Note: USE_CLUSTER_STORAGE was set to true to avoid having to use a ccs cluster

Checked installed operators and can verify that 3scale is cluster scoped.

Screenshot from 2022-01-20 13-28-02

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2409 (a702b73) into master (ef261aa) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2409   +/-   ##
=======================================
  Coverage   63.96%   63.97%           
=======================================
  Files         147      147           
  Lines       34340    34352   +12     
=======================================
+ Hits        21966    21976   +10     
- Misses      11370    11371    +1     
- Partials     1004     1005    +1     
Impacted Files Coverage Δ
pkg/resources/marketplace/manager.go 73.75% <84.61%> (+1.69%) ⬆️
pkg/products/threescale/reconciler.go 46.16% <100.00%> (ø)

MGDAPI-3177 add back in replaces field

MGDAPI-3177 add a createOrUpdate to operatorGroup creation

MGDAPI-3435 change the operatorGroup to clusterscoped on upgrade
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@austincunningham: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants