Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Stripe v4.x #119

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Add support for Stripe v4.x #119

merged 2 commits into from
Dec 4, 2018

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Dec 3, 2018

Fixes #118.

Stripe gem is up to 4.2.x already, so this commit will allow anything below stripe v5.x.

@coveralls
Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 05d7451 on excid3:master into a5135ca on integrallis:master.

@rmm5t
Copy link
Member

rmm5t commented Dec 4, 2018

It looks like our travis builds started failing against Rails 5.2. I'm fairly busy with client work at the moment; I probably won't have time to investigate this for several days (maybe weeks). Does anyone have the time to investigate this and submit a PR to get our build matrix green again?

@excid3
Copy link
Contributor Author

excid3 commented Dec 4, 2018

I'll try and take a look today if I get the chance.

@excid3
Copy link
Contributor Author

excid3 commented Dec 4, 2018

And fixed!

The old way of setting RAW_POST_BODY ahead of time doesn't work since it gets cleared now each request that's made in the tests. Rails 5.2 now has a body param for setting the RAW_POST_BODY and luckily it doesn't affect old versions of Rails so simply adding the new option fixes everything without specific version workarounds.

@rmm5t rmm5t merged commit 8ea37ad into integrallis:master Dec 4, 2018
@rmm5t
Copy link
Member

rmm5t commented Dec 5, 2018

@excid3 Thank you for your help here! v2.2.0 (with stripe v4 support) is released and in the wild:
https://rubygems.org/gems/stripe_event/versions/2.2.0

@excid3
Copy link
Contributor Author

excid3 commented Dec 5, 2018

Awesome, thanks for the new release @rmm5t 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants