fix(etag): fix etag being noisy when no actual state has been changed

github/resource_github_membership.go

@@ -37,6 +37,10 @@ func resourceGithubMembership() *schema.Resource {
 			"etag": {
 				Type:     schema.TypeString,
 				Computed: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return true
+				},
+				DiffSuppressOnRefresh: true,
 			},
 			"downgrade_on_destroy": {
 				Type:        schema.TypeBool,

github/resource_github_repository.go

@@ -360,6 +360,10 @@ func resourceGithubRepository() *schema.Resource {
 			"etag": {
 				Type:     schema.TypeString,
 				Computed: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return true
+				},
+				DiffSuppressOnRefresh: true,
 			},
 			"primary_language": {
 				Type:     schema.TypeString,

github/resource_github_team.go

@@ -89,6 +89,10 @@ func resourceGithubTeam() *schema.Resource {
 			"etag": {
 				Type:     schema.TypeString,
 				Computed: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return true
+				},
+				DiffSuppressOnRefresh: true,
 			},
 			"node_id": {
 				Type:        schema.TypeString,

github/resource_github_team_membership.go

@@ -58,6 +58,10 @@ func resourceGithubTeamMembership() *schema.Resource {
 			"etag": {
 				Type:     schema.TypeString,
 				Computed: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return true
+				},
+				DiffSuppressOnRefresh: true,
 			},
 		},
 	}

github/resource_github_team_repository.go

@@ -55,6 +55,10 @@ func resourceGithubTeamRepository() *schema.Resource {
 			"etag": {
 				Type:     schema.TypeString,
 				Computed: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return true
+				},
+				DiffSuppressOnRefresh: true,
 			},
 		},
 	}