resource/github_repository: Allow setting default_branch to `m… (#150)

* resource/github_repository: Allow setting default branch to master for new repo * Adds test to validate repository can be set to master as default upon creation
integrations · Jul 18, 2019 · 45fb8bf · 45fb8bf
1 parent 400cb4d
commit 45fb8bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/github/resource_github_repository.go b/github/resource_github_repository.go
@@ -170,8 +170,8 @@ func resourceGithubRepositoryCreate(d *schema.ResourceData, meta interface{}) er
 
 	client := meta.(*Organization).client
 
-	if _, ok := d.GetOk("default_branch"); ok {
-		return fmt.Errorf("Cannot set the default branch on a new repository.")
+	if branchName, hasDefaultBranch := d.GetOk("default_branch"); hasDefaultBranch && (branchName != "master") {
+		return fmt.Errorf("Cannot set the default branch on a new repository to something other than 'master'.")
 	}
 
 	orgName := meta.(*Organization).name

diff --git a/github/resource_github_repository_test.go b/github/resource_github_repository_test.go
@@ -739,6 +739,7 @@ resource "github_repository" "foo" {
   allow_rebase_merge = false
   has_downloads      = true
   auto_init          = true
+  default_branch     = "master"
 }
 `, randString, randString)
 }